On Tue, Jan 12, 2016 at 01:29:39PM +0100, Gerd Hoffmann wrote:
> With all fixups being in place now, we can promote input-send-event
> to stable abi by removing the x- prefix.
>
> Signed-off-by: Gerd Hoffmann <[email protected]>
> ---
> qapi-schema.json | 12 +++---------
> qmp-commands.hx | 14 +++++++-------
> ui/input.c | 6 +++---
> 3 files changed, 13 insertions(+), 19 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 35ef71c..a0b6963 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3738,7 +3738,7 @@
> 'abs' : 'InputMoveEvent' } }
>
> ##
> -# @x-input-send-event
> +# @input-send-event
> #
> # Send input event(s) to guest.
> #
> @@ -3759,16 +3759,10 @@
> # specified, both input devices with and without input routing config
> # are admissible, but devices with input routing config take
> # precedence.
> -
> -# Since: 2.2
> -#
> -# Note: this command is experimental, and not a stable API. Things that
> -# might change before it becomes stable include the spelling of enum
> -# values for InputButton and InputAxis, and the notion of how to designate
> -# which console will receive the event.
> #
> +# Since: experimental 2.2, stable 2.6
Couldn't it just be 'Since: 2.6' ? The experimental tag refers to
the old x- prefixed comamnd which no longer exists, so I don't think
we need to admit existence of the old command after this point.
> ##
> -{ 'command': 'x-input-send-event',
> +{ 'command': 'input-send-event',
> 'data': { '*device': 'str',
> '*head' : 'int',
> 'events' : [ 'InputEvent' ] } }
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
