On Fri, Jan 08, 2016 at 06:34:15PM +0100, Igor Mammedov wrote:
> build fail with warnings on w32 compiler:
>
> hw/acpi/memory_hotplug_acpi_table.c:
> In function ‘build_memory_hotplug_aml’:
> hw/acpi/memory_hotplug_acpi_table.c:148:
> warning: integer constant is too large for ‘long’ type
> hw/acpi/memory_hotplug_acpi_table.c:149:
> warning: integer constant is too large for ‘long’ type
>
> fix it by expilictly saying that int const is 64bit number
>
> Signed-off-by: Igor Mammedov <[email protected]>
thanks!
Make it a fixup! patch next time pls.
> ---
> hw/acpi/memory_hotplug_acpi_table.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/acpi/memory_hotplug_acpi_table.c
> b/hw/acpi/memory_hotplug_acpi_table.c
> index 20728ac..080d9ad 100644
> --- a/hw/acpi/memory_hotplug_acpi_table.c
> +++ b/hw/acpi/memory_hotplug_acpi_table.c
> @@ -145,8 +145,8 @@ void build_memory_hotplug_aml(Aml *ctx, uint32_t nr_mem,
> aml_append(crs_tmpl,
> aml_qword_memory(AML_POS_DECODE, AML_MIN_FIXED,
> AML_MAX_FIXED,
> AML_CACHEABLE, AML_READ_WRITE,
> - 0, 0x0, 0xFFFFFFFFFFFFFFFE, 0,
> - 0xFFFFFFFFFFFFFFFF));
> + 0, 0x0, 0xFFFFFFFFFFFFFFFEULL, 0,
> + 0xFFFFFFFFFFFFFFFFULL));
> aml_append(method, aml_name_decl("MR64", crs_tmpl));
> aml_append(method,
> aml_create_dword_field(mr64, aml_int(14), "MINL"));
> --
> 1.8.3.1
