On Thu, 7 Jan 2016 20:55:50 +0100 Laurent Vivier <[email protected]> wrote:
> > > On 07/01/2016 12:32, Greg Kurz wrote: > > It is not used anymore. > > > > Signed-off-by: Greg Kurz <[email protected]> > > --- > > include/hw/virtio/virtio-access.h | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/include/hw/virtio/virtio-access.h > > b/include/hw/virtio/virtio-access.h > > index 8aec843c8ff3..a01fff2e51d7 100644 > > --- a/include/hw/virtio/virtio-access.h > > +++ b/include/hw/virtio/virtio-access.h > > @@ -143,15 +143,6 @@ static inline uint64_t virtio_ldq_p(VirtIODevice > > *vdev, const void *ptr) > > } > > } > > > > -static inline bool virtio_needs_swap(VirtIODevice *vdev) > > -{ > > -#ifdef HOST_WORDS_BIGENDIAN > > - return virtio_access_is_big_endian(vdev) ? false : true; > > -#else > > - return virtio_access_is_big_endian(vdev) ? true : false; > > -#endif > > -} > > - > > I think you can move this to PATCH 1/6 too. > I usually prefer to separate cleanup from functional changes, but indeed this one is trivial... I'll do that and we will see if it helps when I re-post. > > static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s) > > { > > #ifdef HOST_WORDS_BIGENDIAN > > > > >
