On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> + case IPMI_BMC_WATCHDOG_PRE_NMI:
> + if (!k->do_hw_op(s, IPMI_SEND_NMI, 1)) {
> + /* NMI not supported. */
> + rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> + goto out;
> + }
> + default:
> + /* We don't support PRE_SMI */
> + rsp[2] = IPMI_CC_INVALID_DATA_FIELD;
> + goto out;
Hi Michael and Corey,
Coverity here complains that the "case IPMI_BMC_WATCHDOG_PRE_NMI" falls
through to the default case. If anything, you could negate the "if"
condition and then it would make sense to fall through; but given how
the code is written, I think Coverity is correct.
Thanks,
Paolo
