On Mon, Dec 21, 2015 at 09:22:42AM -0700, Eric Blake wrote: > On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > > Add a qcrypto_hash_digest_len() method which allows querying of > > the raw digest size for a given hash algorithm. > > > > Signed-off-by: Daniel P. Berrange <[email protected]> > > --- > > crypto/hash.c | 15 +++++++++++++++ > > include/crypto/hash.h | 11 +++++++++++ > > tests/test-crypto-hash.c | 5 +++++ > > 3 files changed, 31 insertions(+) > > > > > +++ b/tests/test-crypto-hash.c > > @@ -163,6 +163,11 @@ static void test_hash_digest(void) > > for (i = 0; i < G_N_ELEMENTS(expected_outputs) ; i++) { > > int ret; > > char *digest; > > + size_t digestsize; > > + > > + digestsize = qcrypto_hash_digest_len(i); > > + > > + g_assert((digestsize * 2) == strlen(expected_outputs[i])); > > g_assert_cmpint() might be better here. But that's minor.
Ok, I've changed that. > Reviewed-by: Eric Blake <[email protected]> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
