On 12/10/2015 10:32 AM, Eric Blake wrote:
> On 12/07/2015 08:55 PM, Eric Blake wrote:
>
>> We can greatly simplify things by hoisting the special case
>> into the start() routine, and flipping the order in the loop
>> to visit before advance:
>>
>> start(head)
>> element = *head
>> while (element) {
>> visit(element)
>> element = next(element)
>> }
>>> Looking at this, it is inconsistent with start_struct (where name comes > AFTER the object); that is, I think this should probably be: > > void (*start_list)(Visitor *v, GenericList **list, const char *name, > Error **errp); > > although I'll still wait for review comments before respinning. I've also bisected this patch as causing assertion failures in qemu-iotests 041 and 139, so I'll have to sort that out on the respin. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
