On Wed, Dec 02, 2015 at 08:46:49AM +0800, Fam Zheng wrote:
> On Tue, 12/01 21:28, Peter Xu wrote:
> > + if (*errp) {
> > + s->status = DUMP_STATUS_FAILED;
> > + } else {
> > + s->status = DUMP_STATUS_COMPLETED;
> > + }
> > +
>
> To detect error, it's better to use local_err plus error_propagate like a few
> lines above. errp _can_ be NULL depending on callers, though in practice qmp
> functions should get a non-NULL.
Yes, you are right. I will make sure all the error handlings in the
patch set are using local error variables, and call
error_propagate() afterward.
Thanks.
Peter
> > Fam
