On 1 December 2015 at 13:21, Igor Mammedov <[email protected]> wrote:
> On Mon, 16 Nov 2015 21:23:02 +0800
> [email protected] wrote:
>
>> From: Shannon Zhao <[email protected]>
>>
>> ACPI 5.0 supports GPIO-signaled ACPI Events. This can be used for
>> powerdown, hotplug evnets. Add a GPIO controller in machine virt,
> s/evnets/events/
>
>> to support powerdown, maybe can be used for cpu hotplug. And
>> here we use pl061.
>>
> vvvvv
>> + nodename = g_strdup_printf("/pl061@%" PRIx64, base);
>> + qemu_fdt_add_subnode(vbi->fdt, nodename);
>> + qemu_fdt_setprop_sized_cells(vbi->fdt, nodename, "reg",
>> + 2, base, 2, size);
>> + qemu_fdt_setprop(vbi->fdt, nodename, "compatible", compat,
>> sizeof(compat));
>> + qemu_fdt_setprop_cell(vbi->fdt, nodename, "#gpio-cells", 2);
>> + qemu_fdt_setprop(vbi->fdt, nodename, "gpio-controller", NULL, 0);
>> + qemu_fdt_setprop_cells(vbi->fdt, nodename, "interrupts",
>> + GIC_FDT_IRQ_TYPE_SPI, irq,
>> + GIC_FDT_IRQ_FLAGS_LEVEL_HI);
>> + qemu_fdt_setprop_cell(vbi->fdt, nodename, "clocks", vbi->clock_phandle);
>> + qemu_fdt_setprop_string(vbi->fdt, nodename, "clock-names", "apb_pclk");
>> +
>> + g_free(nodename);
> could you split off DT parts into a separate patch pls.
I think they belong in this patch. We should never add a device
to the 'virt' board without having the DT binding for it too.
thanks
-- PMM
