On 25 November 2015 at 18:02, Sergey Fedorov <[email protected]> wrote: > The AArch32 translation completion code for singlestep enabled/active > case was a way more confusing and too repetitive then it needs to be. > Probably that was the cause for a bug to be introduced into it at some > point. The bug was that SWI/HVC/SMC exception would be generated in > condition-failed instruction code path whereas it shouldn't.
So I did some testing, and I think this is a bug that's not actually really visible to Linux guests. For both QEMU's gdbstub and for gdb running within a system emulation, gdb for 32-bit ARM will prefer to do singlestep via setting breakpoints rather than trying to use the gdbstub's singlestep command. So while we should definitely fix it (and the code cleanup is nice) I think we don't need to do this for 2.5, and I'm going to put this on my review-for-2.6 list. Do you agree? thanks -- PMM
