Hi ----- Original Message ----- > Marc-André Lureau <[email protected]> writes: > > > ----- Original Message ----- > >> Marc-André Lureau <[email protected]> writes: > >> > >> > Hi > >> > > >> > ----- Original Message ----- > >> >> Marc-André Lureau <[email protected]> writes: > >> >> > >> >> > ----- Original Message ----- > >> >> >> Signed-off-by: Markus Armbruster <[email protected]> > >> >> >> --- > >> >> >> hw/misc/ivshmem.c | 1 + > >> >> >> 1 file changed, 1 insertion(+) > >> >> >> > >> >> >> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > >> >> >> index 83d7bd3..a6bfdde 100644 > >> >> >> --- a/hw/misc/ivshmem.c > >> >> >> +++ b/hw/misc/ivshmem.c > >> >> >> @@ -939,6 +939,7 @@ static void pci_ivshmem_realize(PCIDevice *dev, > >> >> >> Error > >> >> >> **errp) > >> >> >> memory_region_add_subregion(&s->bar, 0, mr); > >> >> >> pci_register_bar(PCI_DEVICE(s), 2, attr, &s->bar); > >> >> >> } else if (s->server_chr != NULL) { > >> >> >> + /* FIXME replace this test, it works basically by chance */ > >> >> > > >> >> > I wouldn't say it like that, but ack anyway. > >> >> > >> >> I'm happy to consider a rephrased comment. > >> > > >> > Although Paolo used "chance" too, I think the proper comment would be > >> > the following: > >> > > >> > FIXME: only pty and socket chardevs set chr->filename, other set to > >> > the default---the backend name. > >> > >> I'm afraid that doesn't convey what needs fixing. > >> > >> > ie, to me it's not just by "chance" :) > >> > >> Well, it's certainly not by design! > >> > >> What about: > >> > >> + /* FIXME do not rely on what chr drivers put into filename */ > > > > ack > > Will you prepare a pull request, or would you like me to do it? >
Please do it (I am not the ivshmem maintainer ;)
