On 11/24/2015 10:09 AM, Lluís Vilanova wrote:
> A separate ID space ('TRACE_CPU_*') is used in attribute 'cpu_id' that
> only contains events with the 'vcpu' property.
>
> These are later used to select the appropriate physical TB cache based
> on what events are active.
>
> Signed-off-by: Lluís Vilanova <[email protected]>
> ---> +++ b/qapi/trace.json > @@ -1,6 +1,6 @@ > # -*- mode: python -*- > # > -# Copyright (C) 2011-2014 Lluís Vilanova <[email protected]> > +# Copyright (C) 2011-2015 Lluís Vilanova <[email protected]> > # > # This work is licensed under the terms of the GNU GPL, version 2 or later. > # See the COPYING file in the top-level directory. > @@ -29,11 +29,12 @@ > # > # @name: Event name. > # @state: Tracing state. > +# @vcpu: Whether this is a per-vCPU event (since 2.5). You've missed 2.5 hard freeze; this will need to be 2.6. Also, I note that patch 9/10 touches the same line again to make it optional; why not just have it be optional in the beginning, to reduce churn within the series? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
