On Tue, 11/24 13:51, Paolo Bonzini wrote: > > > On 24/11/2015 13:50, Fam Zheng wrote: > > > > + if (bs->file && *file == bs->file->bs && > > > > > > This check is unnecessary, just use "if (file)". > > > > "file" would be bs in the case of protocol, and this function will > > infinitely > > recurse. > > Oh, that's right! But then I think we want to check that and allow > recursion to any *file, not just bs->file->bs. >
That makes sense, I'll make it to. Fam
