On 11/11/2015 03:27, David Gibson wrote:
> Meaning one which adds the hook to the monitor, and another which
> implements it for ppc? Maybe.
>
> I'd like to take this, but I'm not sure whether it's reasonable for
> the small generic monitor change to go through the ppc tree. Peter,
> Paolo, opinion?
I'm not a monitor maintainer, but I think it's okay since there is
none. :)
We probably should replace target_monitor_defs() with an implementation
of target_get_monitor_def on all targets. It can just pass a MonitorDef
array to a common function, i.e.
int lookup_monitor_def(MonitorDef *def, void *base, const char *name, uint64_t
*pval)
static int target_get_monitor_def(CPUState *cs, const char *name, uint64_t
*pval)
{
return lookup_monitor_def(monitor_defs, cs->env_ptr, name, pval);
}
I don't want you to do it now, but we should add it to the wiki
BiteSizedTasks so we don't forget.
Paolo
