On Tue, Oct 27, 2015 at 05:29:43PM +0100, [email protected] wrote:
> From: Marc-André Lureau <[email protected]>
>
> vhost-user-test prints a warning. A test should not need to run on
> hugetlbfs, let's silence the warning under qtest. Unfortunately, the
> condition can't check on qtest_enabled() or qtest_driver() since they
> are initialized later.
>
> Signed-off-by: Marc-André Lureau <[email protected]>
Any idea what's the best way to address this?
Is poking at environment like this appropriate?
Maybe a command line flag to silence the warning?
> ---
> exec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/exec.c b/exec.c
> index 8af2570..d9c231d 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1194,8 +1194,9 @@ static long gethugepagesize(const char *path, Error
> **errp)
> return 0;
> }
>
> - if (fs.f_type != HUGETLBFS_MAGIC)
> + if (fs.f_type != HUGETLBFS_MAGIC && !getenv("QTEST_QEMU_BINARY")) {
> fprintf(stderr, "Warning: path not on HugeTLBFS: %s\n", path);
> + }
>
> return fs.f_bsize;
> }
> --
> 2.4.3
