On 02.11.2015 21:29, Peter Maydell wrote: > On 2 November 2015 at 18:16, Sergey Fedorov <[email protected]> wrote: >> AArch32 translation code does not distinguish between DISAS_UPDATE and >> DISAS_JUMP. Thus, we cannot use any of them without first updating PC in >> CPU state. Furthermore, it is too complicated to update PC in CPU state >> before PC gets updated in disas context. So it is hardly possible to >> correctly end TB early if is is not likely to be executed before calling >> disas_*_insn(), e.g. just after calling breakpoint check helper. >> >> Modify DISAS_UPDATE and DISAS_JUMP usage in AArch32 translation and >> apply to them the same semantic as AArch64 translation does: >> - DISAS_UPDATE: update PC in CPU state when finishing translation >> - DISAS_JUMP: preserve current PC value in CPU state when finishing >> translation > Is this fixing the breakpoint related bug? If so the commit message > should say so. Otherwise it just looks like cleanup... > > (I'll review the patch tomorrow.)
Yes it's fixing a bug in breakpoint handling. I'll update the commit message. Best, Sergey
