"Denis V. Lunev" <[email protected]> writes:
> The following is done:
> - QMP/HMP events are now logged
> - timestamp is added to the log message
> - arguments of qemu_log/qemu_log_mask are not calculated now if the log
> is disabled
>
> These patches are sent in the hope that it is not too late for QEMU 2.5.
>
> Logging subsystem in QEMU looks rudimentary to me and should be definitely
> improved, f.e. log on stalled NFS could ruin the system completely. Anyway,
> it is too late for this at the moment.
Logging QMP traffic makes sense to me.
However, I don't think logging QMP/HMP traffic to the existing -D
logfile is a good idea, because in its current state, that logfile is
mostly for TCG tracing.
Regardless, this series has led to a fruitful (I think) discussion of
logging and tracing ("What's the intended use of log.h logging?"), and
then to Paolo's "[PATCH 0/9] simplify usage of tracepoints, and connect
them to logging". Let's see where this leads us, and how much we can
still do for 2.5.
