On 10/14/2015 02:08 PM, Michael Roth wrote: > From: Yuri Pudgorodskiy <y...@virtuozzo.com> > > Guest-exec rewriten in platform-independant style with glib spawn.
s/rewriten/rewritten/
s/independant/independent/
>
> Child process is spawn asynchroneously and exit status can later
s/asynchroneously/asynchronously/
> be picked up by guest-exec-status command.
>
> stdin/stdout/stderr of the child now is redirected to /dev/null
> Later we will add ability to specify stdin in guest-exec command
> and to get collected stdout/stderr with guest-exec-status.
>
> Signed-off-by: Yuri Pudgorodskiy <y...@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <d...@openvz.org>
> CC: Michael Roth <mdr...@linux.vnet.ibm.com>
> *use g_new0 in place of g_malloc for GuestExec struct
> Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com>
> ---
> +##
> +# @guest-exec:
> +#
> +# Execute a command in the guest
> +#
> +# @path: path or executable name to execute
> +# @arg: #optional argument list to pass to executable
> +# @env: #optional environment variables to pass to executable
> +# @inp-data: #optional data to be passed to process stdin (base64 encoded)
Should this be 'input-data' instead of abbreviating?
> +# @capture-output: #optional bool flags to enable capture of
> +# stdout/stderr of running process
Might be worth mentioning that the default is false.
> +#
> +# Returns: PID on success.
> +#
> +# Since: 2.5
> +##
> +{ 'command': 'guest-exec',
> + 'data': { 'path': 'str', '*arg': ['str'], '*env': ['str'],
> + '*inp-data': 'str', '*capture-output': 'bool' },
> + 'returns': 'GuestExec' }
Are there any restrictions on how elements of env must behave, such as
requiring an '='? If so, does that mean we need any more structure than
a raw 'str', such as {'name':'str', 'value':'str'}? Or is that overkill?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
