On 12/10/2015 17:16, Eric Blake wrote:
>> rp)
>> > {
>> > + ChardevHostdev *opts = backend->pipe;
>> > int fd_in, fd_out;
>> > char filename_in[CHR_MAX_FILENAME_SIZE];
>> > char filename_out[CHR_MAX_FILENAME_SIZE];
>> > const char *filename = opts->device;
>> >
>> > - if (filename == NULL) {
>> > - fprintf(stderr, "chardev: pipe: no filename given\n");
>> > - return NULL;
>> > - }
>> > -
>> > snprintf(filename_in, CHR_MAX_FILENAME_SIZE, "%s.in", filename);
> Do we need assert(filename) here?
>
>
No, "device" is not optional in the definition of ChardevHostdev.
Paolo
