On 09/03/2015 12:33 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <[email protected]>
>> Signed-off-by: zhanghailiang <[email protected]>
>> Signed-off-by: Gonglei <[email protected]>
>> Cc: Luiz Capitulino <[email protected]>
>> Cc: Michael Roth <[email protected]>
>> Reviewed-by: Paolo Bonzini <[email protected]>
>> ---
>> block.c | 43 +++++++++++++++++++++++++++++++++++++++++++
>> include/block/block.h | 5 +++++
>> include/block/block_int.h | 14 ++++++++++++++
>> qapi/block-core.json | 15 +++++++++++++++
>> 4 files changed, 77 insertions(+)
>>
>
> Just an interface review for now:
>
>> +++ b/qapi/block-core.json
>> @@ -1810,6 +1810,21 @@
>> 'data': { '*export': 'str' } }
>>
>> ##
>> +# @ReplicationMode
>> +#
>> +# An enumeration of replication modes.
>> +#
>> +# @unprotected: Replication is not started or after failover.
>
> Maybe:
>
> Replication is either not started, or has experienced failover.
This is internal state, and this mode is used to tell qemu that
it is on which side.
Thanks
Wen Congyang
>
>> +#
>> +# @primary: Primary mode, the vm's state will be sent to secondary QEMU.
>> +#
>> +# @secondary: Secondary mode, receive the vm's state from primary QEMU.
>> +#
>> +# Since: 2.4
>
> You've missed 2.4; this should be 2.5.
>
>> +##
>> +{ 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
>
> Where is 'unprotected' in this list?
>
