On Tue 15 Sep 2015 04:27:21 AM CEST, Fam Zheng <[email protected]> wrote:
>> + backing = qdict_get_try_str(options, "backing");
>> + if (backing && *backing == '\0') {
>> + flags |= BDRV_O_NO_BACKING;
>> + }
>> + qdict_del(options, "backing");
>> +
> Specifying a non-empty "backing" will be a slient nop now, but it used
> to be an error before. Should we return an error?
Ah, yes, I think it should return an error. Thanks!
--- a/block.c
+++ b/block.c
@@ -1473,8 +1473,8 @@ static int bdrv_open_inherit(BlockDriverState
**pbs, const char *filename,
backing = qdict_get_try_str(options, "backing");
if (backing && *backing == '\0') {
flags |= BDRV_O_NO_BACKING;
+ qdict_del(options, "backing");
}
- qdict_del(options, "backing");
Berto
