On 14 September 2015 at 16:59, Eric Blake <ebl...@redhat.com> wrote: > On 09/14/2015 08:15 AM, Leon Alrae wrote: >> Include linux/vfio.h after sys/ioctl.h, just like in hw/vfio/common.c and >> hw/vfio/platform.c. >> >> This fixes the regression caused by the change in commit d7646f2: > > How much longer are we planning on building on CentOS 5? Didn't we > already break things with a glib minimum requirement in qemu 2.5, plus > the now-pending bump to python 2.6?
It's not supported by us (upstream) any more (since 2.4). > While I'm not opposed to this patch, I'm wondering if it will make any > real difference. Anybody wanting to build on Centos 5 is going to need to start building/backporting their dependent libraries and build tools, yes. But where the changes to fix compilation issues are trivial, like this one, I don't see any reason for us not to accept them. thanks -- PMM
