On 09/03/2015 03:01 AM, Eric Blake wrote:
> On 09/02/2015 02:51 AM, Wen Congyang wrote:
>> Signed-off-by: Wen Congyang <[email protected]>
>> Signed-off-by: zhanghailiang <[email protected]>
>> Signed-off-by: Gonglei <[email protected]>
>
> Commit message is a bit sparse.
>
>> ---
>> include/qemu/option.h | 2 ++
>> util/qemu-option.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 46 insertions(+)
>>
>
> Missing testsuite exposure of the new function.
Do you mean: update tests/test-qemu-opts.c?
>
>> /*
>> + * Adds all QDict entries to the QemuOpts that can be added and removes them
>> + * from the QDict. The key starts with "%index." in the %qdict. When this
>
> "%index." reads awkwardly (I thought it was a printf-style format). But
> I'm not sure if "starts with %index followed by '.'" is any better.
The other comments use '@'. I will update it in the next version.
>
>> + * function returns, the QDict contains only those entries that couldn't be
>> + * added to the QemuOpts.
>> + */
>> +void qemu_opts_absorb_qdict_by_index(QemuOpts *opts, QDict *qdict,
>> + const char *index, Error **errp)
>> +{
>
> I didn't review the algorithm closely, but here's a superficial comment:
>
>> + const QDictEntry *entry, *next;
>> + const char *key;
>> + int len = strlen(index);
>
> size_t
OK, will fix it in the next version.
Thanks
Wen Congyang
>
