On 1 September 2015 at 18:47, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 31 August 2015 at 10:10, Marc Marí <mar...@redhat.com> wrote: >> +=== ARM Register Locations === >> + >> +Selector Register address: 0x09020000 >> +Data Register address: 0x09020008 >> +DMA Address address: 0x0902000c > > These addresses shouldn't be documented -- the correct API is that the guest > needs to find the base address of the fw_cfg device via device tree > or ACPI table. You can document the layout of the registers within the > device, obviously (ie +0, +4, +8).
...and this is not what your patchset implements anyway. This should be: offset 0: data register (8 bytes wide) offset 8: selector register (4 bytes wide) offset 12: reserved offset 16: DMA address register (8 bytes wide) thanks -- PMM
