From: Liu Yuan <[email protected]> We need to discard the payload if we get a invalid header due to whatever reason to avoid data stream curruption. For e.g., the response consists of header plus data payload. If we simply read the header then the data payload is left in the socket buffer and the next time we would read the garbage data and currupt the whole connection.
Cc: [email protected] Cc: Jeff Cody <[email protected]> Cc: Kevin Wolf <[email protected]> Cc: Stefan Hajnoczi <[email protected]> Signed-off-by: Liu Yuan <[email protected]> --- block/sheepdog.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 9585beb..9ed3458 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -794,6 +794,14 @@ static void coroutine_fn aio_read_response(void *opaque) } } if (!aio_req) { + if (rsp.data_length) { + void *garbage = g_malloc(rsp.data_length); + ret = qemu_co_recv(fd, garbage, rsp.data_length); + if (ret != rsp.data_length) { + error_report("failed to discard the data, %s", strerror(errno)); + } + g_free(garbage); + } error_report("cannot find aio_req %x", rsp.id); goto err; } -- 1.9.1
