On 30 August 2015 at 20:03, Timothy E Baldwin <[email protected]> wrote: > Whilst calls to do_fork() are wrapped in get_errno() this does not > translate return values. > > Signed-off-by: Timothy Edward Baldwin <[email protected]> > --- > linux-user/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index f62c698..bca3424 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -4623,7 +4623,7 @@ static int do_fork(CPUArchState *env, unsigned int > flags, abi_ulong newsp, > } else { > /* if no CLONE_VM, we consider it is a fork */ > if ((flags & ~(CSIGNAL | CLONE_NPTL_FLAGS2)) != 0) > - return -EINVAL; > + return -TARGET_EINVAL; > fork_start(); > ret = fork(); > if (ret == 0) {
Reviewed-by: Peter Maydell <[email protected]> It would be nice to add the coding-style mandated braces to the if() since you're touching it anyway, though. thanks -- PMM
