On Mon, Aug 24, 2015 at 02:25:24PM -0600, Eric Blake wrote:
> > +/* #define QCRYPTO_DEBUG */
> > +
> > +#ifdef QCRYPTO_DEBUG
> > +#define DPRINTF(fmt, ...) do { fprintf(stderr, fmt, ## __VA_ARGS__); }
> > while (0)
> > +#else
> > +#define DPRINTF(fmt, ...) do { } while (0)
> > +#endif
>
> Please rework this to:
>
> #ifdef QCRYPTO_DEBUG
> # define QCRYPT_DEBUG_PRINT 1
> #else
> # define QCRYPT_DEBUG_PRINT 0
> #endif
> #define DPRINTF(fmt, ...) \
> do { \
> if (QCRYPT_DEBUG_PRINT) { \
> fprintf(stderr, fmt, ## __VA_ARGS__); \
> } \
> } while (0)
Ah that's a good idea.
One day it would nice if QEMU had a standardized debug logging macro
in qemu-common.h, so we could just turn on/off debugging per file
using
#define ENABLE_DEBUG 1
#include "qemu-common.h"
> > +#define DH_BITS 2048
> > +
> > +static const char * const endpoint_map[QCRYPTO_TLS_CREDS_ENDPOINT_LAST +
> > 1] = {
> > + [QCRYPTO_TLS_CREDS_ENDPOINT_SERVER] = "server",
> > + [QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT] = "client",
> > + [QCRYPTO_TLS_CREDS_ENDPOINT_LAST] = NULL,
> > +};
>
> Is it worth an entry in a .json file to get qapi to generate this
> mapping automatically?
I guess adding the enum definition itself to QAPI would mean we
would get better introspection support when we solve QOM class
introspection of properties.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
