John Snow <[email protected]> writes: > On 07/02/2015 11:31 AM, Luiz Capitulino wrote: >> On Wed, 1 Jul 2015 14:25:49 -0400 >> John Snow <[email protected]> wrote: >> >>> I should probably document the changes that were made.
John, what do you mean here? >>> Signed-off-by: John Snow <[email protected]> >> >> Looks good to me, CC'ing maintainer. Luiz, is this a R-by? > Whoops, didn't realize Markus took this file over, too. Sorry Luiz. Don't worry about our maintainer reshuffling. > Markus, would you consider staging this? It's purely a documentation > update for only a dev tool, so it doesn't really matter /when/ it lands > either way, just shoring up some changes I made a while back to the > interpreter here. > > tldr: "ping" I'm happy to include this in the next pull after it got reviewed. I'm ignorant about qmp-shell, because I don't use it myself, so I'd have to dig through it to verify your documentation is accurate and reasonably complete. Fishing for more qualified reviewers: $ scripts/get_maintainer.pl --git-blame -f scripts/qmp/qmp-shell Markus Armbruster <[email protected]> (supporter:QMP) Luiz Capitulino <[email protected]> (authored lines:230/390=59%,commits:10/10=100%) John Snow <[email protected]> (authored lines:117/390=30%,commits:4/10=40%) "Daniel P. Berrange" <[email protected]> (authored lines:27/390=7%) Eric Blake <[email protected]> (commits:6/10=60%) Stefan Hajnoczi <[email protected]> (commits:2/10=20%) Benoit Canet <[email protected]> (commits:1/10=10%) Luiz, can you review for accuracy and reasonable completeness? Of course, I'm the reviewer of last resort for anything I maintain, whether I understand it or not :)
