On Fri, Jul 17, 2015 at 12:56:15PM +0200, Kevin Wolf wrote:
> Am 17.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben:
> > QEMU silently ignores aio=native if libaio is unavailable.  It is
> > confusing when aio=native performance is identical to aio=threads
> > because the binary was accidentally built without libaio.
> > 
> > Use error_report() because failing would break backward compatibility.
> > There are probably users using aio=native who would be inconvenienced if
> > QEMU suddenly refused to start their guests.
> > 
> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> 
> I hope not too many people are using aio=native without having libaio
> compiled in... Can we make it a message like for the case with
> aio=native,cache.direct=off, i.e. a deprecation warning that allows us
> to make this an error in a few releases?

Yes, I'll move the warning to raw-posix.c so all callers benefit from
it.

Attachment: pgpoOON4yc1s8.pgp
Description: PGP signature

Reply via email to