On 2015-07-09 16:57, Paolo Bonzini wrote: > This was dereferencing a pointer before checking if it was NULL. > > Reported-by: Christian Borntraeger <[email protected]> > Reported-by: Aurelien Jarno <[email protected]> > Signed-off-by: Paolo Bonzini <[email protected]> > --- > crypto/cipher-builtin.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c > index c625cb4..912c1b9 100644 > --- a/crypto/cipher-builtin.c > +++ b/crypto/cipher-builtin.c > @@ -354,11 +354,13 @@ QCryptoCipher > *qcrypto_cipher_new(QCryptoCipherAlgorithm alg, > > void qcrypto_cipher_free(QCryptoCipher *cipher) > { > - QCryptoCipherBuiltin *ctxt = cipher->opaque; > + QCryptoCipherBuiltin *ctxt; > + > if (!cipher) { > return; > } > > + ctxt = cipher->opaque; > ctxt->free(cipher); > g_free(cipher); > }
Thanks for the quick fix. Reviewed-by: Aurelien Jarno <[email protected]> Tested-by: Aurelien Jarno <[email protected]> -- Aurelien Jarno GPG: 4096R/1DDD8C9B [email protected] http://www.aurel32.net
