On Tue, Jul 07, 2015 at 15:09:05 +0200, Juan Quintela wrote:
> Make check fails with events. THis is due to the parser/lexer that it
> uses. Just in case that they are more broken parsers, just only send
> events when there are capabilities.
>
> Signed-off-by: Juan Quintela <[email protected]>
> Reviewed-by: Dr. David Alan Gilbert <[email protected]>
...
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 106008c..1285b8c 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -523,6 +523,9 @@
> # minimize migration traffic. The feature is disabled by default.
> # (since 2.4 )
> #
> +# @events: generate events for each migration state change
> +# (since 2.4 )
> +#
> # @auto-converge: If enabled, QEMU will automatically throttle down the guest
> # to speed up convergence of RAM migration. (since 1.6)
> #
> @@ -530,7 +533,7 @@
> ##
> { 'enum': 'MigrationCapability',
> 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks',
> - 'compress'] }
> + 'compress', 'events'] }
>
Perhaps I messed something up, but I don't see this new capability
documented in qmp-commands.hx and
{"execute":"query-migrate-capabilities"} does not report its status:
{
"return": [
{
"state": false,
"capability": "xbzrle"
},
{
"state": false,
"capability": "rdma-pin-all"
},
{
"state": false,
"capability": "auto-converge"
},
{
"state": false,
"capability": "zero-blocks"
},
{
"state": false,
"capability": "compress"
}
]
}
Blindly setting it does not work either:
{
"execute": "migrate-set-capabilities",
"arguments": {
"capabilities": [
{
"capability": "events",
"state": "true"
}
]
}
}
returns
{
"error": {
"class": "GenericError",
"desc": "Invalid parameter 'events'"
}
}
Jirka
