On 2015-07-06 11:25, Pavel Dovgalyuk wrote: > This patch introduces several helpers to pass return address > which points to the TB. Correct return address allows correct > restoring of the guest PC and icount. These functions should be used when > helpers embedded into TB invoke memory operations. > > Reviewed-by: Richard Henderson <[email protected]>
Given that you have changed the patch, the reviewed-by should have been removed. > Signed-off-by: Pavel Dovgalyuk <[email protected]> > --- > include/exec/cpu_ldst_template.h | 59 > +++++++++++++++++++++++++---- > include/exec/cpu_ldst_useronly_template.h | 25 ++++++++++++ > softmmu_template.h | 6 --- > tcg/tcg.h | 23 +++++++++++ > 4 files changed, 99 insertions(+), 14 deletions(-) > That said it looks fine to me, so you can add mine: Reviewed-by: Aurelien Jarno <[email protected]> -- Aurelien Jarno GPG: 4096R/1DDD8C9B [email protected] http://www.aurel32.net
