On 04/07/2015 9:24 pm, "Peter Maydell" <[email protected]> wrote: > > On 4 July 2015 at 00:11, Edgar E. Iglesias <[email protected]> wrote: > > > > > > On Tue, Jun 30, 2015 at 4:25 AM, Peter Maydell <[email protected] > > > wrote: > >> > >> The arm_gic_common reset function was missing reset code for > >> several of the GIC's state fields: > >> * bpr[] > >> * abpr[] > >> * priority1[] > >> * priority2[] > >> * sgi_pending[] > >> * irq_target[] (SMP configurations only) > >> > >> These probably went unnoticed because most guests will either > >> never touch them, or will write to them in the process of > >> configuring the GIC before enabling interrupts. > >> > >> Signed-off-by: Peter Maydell <[email protected]> > > > > > > > > Reviewed-by: Edgar E. Iglesias <[email protected]> > > I assume you meant to send that to the list? :-)
Yes sorry :-) Cheers, Edgar > > Thanks for the review. > > -- PMM
