On 02/07/2015 16:18, Laurent Vivier wrote:
>> > I'm okay with doing the simple thing, but it needs a comment for
>> > non-BSDers.
> So, what we have to do, in our case, for MacOS X cdrom, is something like:
>
> ... GetBSDPath ...
> ...
> if (flags & BDRV_O_NOCACHE) {
> strcat(bsdPath, "r");
> }
> ...
>
> ?
Well, what to do with Mac OS X CD-ROM is another story... Raw access
"seems not do work well" according to John, so we may have a comment
there explaining why we're not adding the "r".
A FIXME comment saying "we should probe for alignment here" would be
placed where you check S_ISCHR and set need_alignment to true.
Paolo
