Re: [Qemu-devel] [PATCH 14/16] nvdimm: support NFIT_CMD_GET_CONFIG_SIZE function

[Stefan Hajnoczi]

On Wed, Jul 01, 2015 at 10:50:30PM +0800, Xiao Guangrong wrote:
> +static uint32_t dsm_cmd_config_size(struct dsm_buffer *in, struct dsm_out 
> *out)
> +{
> +    GSList *list = get_nvdimm_built_list();
> +    PCNVDIMMDevice *nvdimm = get_nvdimm_device_by_handle(list, in->handle);
> +    uint32_t status = NFIT_STATUS_NON_EXISTING_MEM_DEV;
> +
> +    if (!nvdimm) {
> +        goto exit;
> +    }
> +
> +    status = NFIT_STATUS_SUCCESS;
> +    out->cmd_config_size.config_size = nvdimm->config_data_size;
> +    out->cmd_config_size.max_xfer = max_xfer_config_size();

cpu_to_*() missing?

It should be possible to emulate NVDIMMs for a x86_64 guest on a
big-endian host, for example.

pgpnVCcVs6MBv.pgp
Description: PGP signature