[Qemu-devel] [PATCH v8 1/8] vmport: Switch to trace

[Don Slutz]

From: Don Slutz <dsl...@verizon.com>

Signed-off-by: Don Slutz <dsl...@verizon.com>
CC: Don Slutz <don.sl...@gmail.com>
Acked-by: Paolo Bonzini <pbonz...@redhat.com>
---
v8:
  Added Acked-by: Paolo Bonzini

 hw/misc/vmport.c | 6 ++----
 trace-events     | 3 +++
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c
index 7fcc00d..3b81d04 100644
--- a/hw/misc/vmport.c
+++ b/hw/misc/vmport.c
@@ -27,7 +27,7 @@
 #include "sysemu/kvm.h"
 #include "hw/qdev.h"
 
-//#define VMPORT_DEBUG
+#include "trace.h"
 
 #define VMPORT_CMD_GETVERSION 0x0a
 #define VMPORT_CMD_GETRAMSIZE 0x14
@@ -80,9 +80,7 @@ static uint64_t vmport_ioport_read(void *opaque, hwaddr addr,
         return eax;
     if (!s->func[command])
     {
-#ifdef VMPORT_DEBUG
-        fprintf(stderr, "vmport: unknown command %x\n", command);
-#endif
+        trace_vmport_ioport_unknown_command(command);
         return eax;
     }
 
diff --git a/trace-events b/trace-events
index 90099e6..80e8a76 100644
--- a/trace-events
+++ b/trace-events
@@ -889,6 +889,9 @@ pc87312_info_ide(uint32_t base) "base 0x%x"
 pc87312_info_parallel(uint32_t base, uint32_t irq) "base 0x%x, irq %u"
 pc87312_info_serial(int n, uint32_t base, uint32_t irq) "id=%d, base 0x%x, irq 
%u"
 
+# hw/misc/vmport.c
+vmport_ioport_unknown_command(unsigned char command) "%x"
+
 # hw/scsi/vmw_pvscsi.c
 pvscsi_ring_init_data(uint32_t txr_len_log2, uint32_t rxr_len_log2) "TX/RX 
rings logarithms set to %d/%d"
 pvscsi_ring_init_msg(uint32_t len_log2) "MSG ring logarithm set to %d"
-- 
1.8.3.1