<[email protected]> wrote: > From: Gonglei <[email protected]> > > Variable "r" going out of scope leaks the storage > it points to in line 3268. > > Signed-off-by: Gonglei <[email protected]> > Reviewed-by: Amit Shah <[email protected]> > --- > v2: > - Drop needless initialization. (Markus & Paolo) > - add Amit's R-by. > --- > migration/rdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Juan Quintela <[email protected]> Applied, thanks. > > diff --git a/migration/rdma.c b/migration/rdma.c > index cf5de7e..b5f9f82 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -3262,12 +3262,13 @@ static const QEMUFileOps rdma_write_ops = { > > static void *qemu_fopen_rdma(RDMAContext *rdma, const char *mode) > { > - QEMUFileRDMA *r = g_malloc0(sizeof(QEMUFileRDMA)); > + QEMUFileRDMA *r; > > if (qemu_file_mode_is_not_valid(mode)) { > return NULL; > } > > + r = g_malloc0(sizeof(QEMUFileRDMA)); > r->rdma = rdma; > > if (mode[0] == 'w') {
