On Tue, Jun 09, 2015 at 06:40:48AM -0400, Stefan Berger wrote:
> > +
> > + if (misc->tpm_version != TPM_VERSION_UNSPEC) {
> > + dev = aml_device("ISA.TPM");
> > + aml_append(dev, aml_name_decl("_HID",
> > aml_eisaid("PNP0C31")));
> > + aml_append(dev, aml_name_decl("_STA", aml_int(0xF)));
> > + crs = aml_resource_template();
> > + aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
> > + TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
> > + aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ));
> > + aml_append(dev, aml_name_decl("_CRS", crs));
> > + aml_append(scope, dev);
> > + }
> > +
> > aml_append(sb_scope, scope);
>
> Once we add the _DSM to it from the link below, it will become longer and
> maybe
> also more complicated. So I would put it into its own function already?
> http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg05353.html
>
> My preference would be to wait until that _DSM has been added to it.
>
That would make Igor do even more work rewriting code from ASL to C.
This patch shows C isn't harder than DSL so I don't think
we can justify doing the work twice.
I'll apply this as-is for now.
--
MST
