On Fri, Jun 19, 2015 at 02:52:16PM +0200, Laszlo Ersek wrote: > > Your merge is closer to a rewrite than to conflict resolution, rendering > > my R-by totally meaningless. > > > > In the future, please either fully test such a merge, or ask the > > submitter / reviewers to review and test. > > Yes, please. While I *was* Cc'd on this patch in the pull request, I > didn't review it. I never expect PULLs to amount to such intrusive > changes -- I treat them only as a hint that my patch is going in -- so > if such changes are necessary (because the original patch doesn't apply > any longer), then please ask me to rebase, or give me an explicit > heads-up that my verification / testing is needed. > > Thanks! > Laszlo
Yes, this wasn't intentional. I don't really remember what went here, sorry. Once thing we do need is a unit test for the floppy. the easiest way to do it is probably by booting a guest, using the bios tables test infrastructure. -- MST
