On 06/16/2015 06:53 AM, Michael S. Tsirkin wrote: > makes it possible to copy error_abort pointers, > not just pass them on directly. > > Signed-off-by: Michael S. Tsirkin <[email protected]> > --- > util/error.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-)
Where is this patch needed? Is the goal to allow: Error err = error_abort; as a way to statically initialize err via copy to behave the same as the global error_abort? But that's not how you were using it in patch 3. There, you were initializing Error *, so using &error_abort is still useful there, and pointer equality still suffices. I don't see a convincing use for this patch. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
