[Qemu-devel] [RFC v8 07/13] vfio: add check for vfio devices which enable aer should support bus reset

[Chen Fan]

Signed-off-by: Chen Fan <chen.fan.f...@cn.fujitsu.com>
---
 hw/vfio/pci.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 15f182c..6de268d 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3791,6 +3791,32 @@ out:
     g_free(info);
 }
 
+static void vfio_pci_machine_done_notify(Notifier *notifier, void *unused)
+{
+    VFIOGroup *group;
+    VFIODevice *vbasedev;
+    VFIOPCIDevice *vdev;
+
+    /* Check All support AER devices if has bus reset capability */
+    QLIST_FOREACH(group, &vfio_group_list, next) {
+        QLIST_FOREACH(vbasedev, &group->device_list, next) {
+            vdev = container_of(vbasedev, VFIOPCIDevice, vbasedev);
+            vfio_check_host_bus_reset(vdev);
+            if ((vdev->features & VFIO_FEATURE_ENABLE_AER) &&
+                !vdev->has_bus_reset) {
+                error_report("vfio: Cannot enable AER for device %s, "
+                             "which is not support host bus reset.",
+                             vdev->vbasedev.name);
+                exit(1);
+            }
+        }
+    }
+}
+
+static Notifier machine_notifier = {
+    .notify = vfio_pci_machine_done_notify,
+};
+
 static int vfio_initfn(PCIDevice *pdev)
 {
     VFIOPCIDevice *vdev = DO_UPCAST(VFIOPCIDevice, pdev, pdev);
@@ -4076,6 +4102,11 @@ static const TypeInfo vfio_pci_dev_info = {
 static void register_vfio_pci_dev_type(void)
 {
     type_register_static(&vfio_pci_dev_info);
+    /*
+     * Register notifier when machine init is done, since we need
+     * check the configration manner after all vfio devices are inited.
+     */
+    qemu_add_machine_init_done_notifier(&machine_notifier);
 }
 
 type_init(register_vfio_pci_dev_type)
-- 
1.9.3