From: Fam Zheng <[email protected]> Bogus image may have a large total_sectors that will overflow the multiplication. For cleanness, fix the return code so the error message will be meaningful.
Reported-by: Richard W.M. Jones <[email protected]> Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Kevin Wolf <[email protected]> --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index 325f727..f42d70e 100644 --- a/block.c +++ b/block.c @@ -2341,6 +2341,7 @@ int64_t bdrv_getlength(BlockDriverState *bs) { int64_t ret = bdrv_nb_sectors(bs); + ret = ret > INT64_MAX / BDRV_SECTOR_SIZE ? -EFBIG : ret; return ret < 0 ? ret : ret * BDRV_SECTOR_SIZE; } -- 1.8.3.1
