On Tue, Apr 28, 2015 at 05:16:35AM +0200, Andreas Färber wrote: > Am 10.04.2015 um 00:48 schrieb Andreas Färber: > > Am 09.04.2015 um 22:22 schrieb Paolo Bonzini: > >> On 09/04/2015 21:57, Eduardo Habkost wrote: > >>> This helps us avoid memory leaks when using object_property_add_alias(), > >>> as it > >>> is not practical for callers to save target_name to free it later. > >>> > >>> Eduardo Habkost (2): > >>> qom: strdup() target property name on object_property_add_alias() > >>> qdev: Free property names after registering gpio aliases > >>> > >>> hw/core/qdev.c | 2 ++ > >>> qom/object.c | 5 +++-- > >>> 2 files changed, 5 insertions(+), 2 deletions(-) > >>> > >> > >> Good idea! > >> > >> Reviewed-by: Paolo Bonzini <[email protected]> > > > > Looks good to me in general, I'm just surprised that there are not more > > cleanups resulting out of this? At least my pc87312 series will need > > changes then. Will take a deeper look another day. > > Thanks, applied to qom-next: > https://github.com/afaerber/qemu-cpu/commits/qom-next
Thanks. Is it expected to appear in a pull request soon? This is needed for the X86CPU properties patch that's on the x86 queue. -- Eduardo
