On 05/08/2015 02:10 PM, Eric Blake wrote: > On 05/08/2015 11:47 AM, Dimitris Aragiorgis wrote: >> Building the QEMU tools fails if we #define DEBUG_BLOCK inside >> block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y >> so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with >> a simple DPRINTF(). >>
> Please fix this to ensure that we avoid bit-rot even when debugging is
> not turned on. Something like:
>
> #ifdef DEBUG_BLOCK
> # define DEBUG_BLOCK_PRINT 1
> #else
> # define DEBUG_BLOCK_PRINT 0
> #endif
> #define DPRINTF(fmt, ...) \
> do \
> if (DEBUG_BLOCK_PRINT) { \
> printf(fmt, ## __VA_ARGS__); \
> while (0)
Obviously, with the missing } that allows compilation :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
