On 05/05/2015 04:22 PM, John Snow wrote: > qtest currently has a static buffer of size 1024 that if we > overflow, ignores the additional data silently which leads > to hangs or stream failures. > > Use glib's string facilities to allow arbitrarily long data, > but split this off into a new function, qtest_sendf. > > Static data can still be sent using qtest_send, which avoids > the malloc/copy overflow.
Did you mean 'overhead' instead of 'overflow'? > > Signed-off-by: John Snow <js...@redhat.com> > --- > qtest.c | 46 ++++++++++++++++++++++++++++------------------ > 1 file changed, 28 insertions(+), 18 deletions(-) > > qtest_send_prefix(chr); > - qtest_send(chr, "FAIL Unknown command `%s'\n", words[0]); > + qtest_sendf(chr, "FAIL Unknown command `%s'\n", words[0]); > } Unrelated - these days, I don't see `this' quoting much any more (except in m4); most people have moved to 'this' quoting. We could clean it while touching this line, but it really doesn't affect correctness either way. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
