On Tue, Apr 28, 2015 at 06:17:32PM +0200, Kashyap Chamarthy wrote:
[. . .]
> > Seems like a regression from your v2.
> >
> > It fails here, even for a non-transaction command, with your patch series
> > applied:
> >
> > (QEMU) blockdev-snapshot-internal-sync device=drive-ide0-0-0
> > name=snapshot0
> > Error while parsing command line: global name '_QMPShell__parse_value' is
> > not defined
> > command format: <command-name> [arg-name1=arg1] ... [arg-nameN=argN]
>
> I now tested again with your qmp-shell-plus branch:
>
> $ git describe
> v2.3.0-rc4-4-g994af97
>
> $ git log --oneline | head -4
> 994af97 scripts: qmp-shell: Add verbose flag
> 1009369 scripts: qmp-shell: add transaction subshell
> 0ae65ff scripts: qmp-shell: Expand support for QMP expressions
> 5f367d9 scripts: qmp-shell: refactor helpers
>
> Result:
>
> - The non-transaction commands work just fine; so that regression is
> fixed in your qmp-shell-plus branch.
> - The transaction command (same commands as tested previously,
> retained it below) still fails.
Tested with your newer branch[1], this time, good news -- from my
minimal testing, no regressions found while running transactional/
non-transactional commands.
As a transactional subshell test, I ran a three-combination command like
below:
(QEMU) transaction(
TRANS> blockdev-snapshot-sync device=drive-ide0-0-0
snapshot-file=./ext-snap2.qcow2 format=qcow2
TRANS> blockdev-snapshot-internal-sync device=drive-ide0-0-0 name=snapshot1
TRANS> drive-backup device=drive-ide0-0-0 sync=full
target=./backup-copy.qcow2 mode=absolute-paths format=qcow2
TRANS> )
{"return": {}}
(QEMU)
When you submit a new version to the list, FWIW, you can carry my
'Tested-by'.
[1] https://github.com/jnsnow/qemu/tree/qmp-shell%2B%2B
--
/kashyap
