On 04/29/2015 12:48 AM, Markus Armbruster wrote: > General question first: through which tree should this go? > > MAINTAINERS doesn't cover the QAPI generators. Closest related stanza > is QAPI (Luiz, Michael R.). Should it cover the generators? Next > closest is QAPI Schema (Luiz, you, myself). > > For completeness: because we touch qmp_query_pci_bridge() and > qmp_query_pci_devices(), get_maintainers.pl also fingers the PCI tree. > > If nobody objects, I can take it through my tree. Cc'ing the > maintainers just mentioned to give them a chance to chime in.
Works for me, but that means we may want to also add the qapi generators into MAINTAINERS along-side QAPI Schema for future changes. Of course, as a separate patch. >> Easier as a followup? Respin just the one patch? Or bite the bullet and >> rebase the entire series (fixing the other trivial items and adding R-b >> along the way)? > > I think we can either > > * Respin, but keep the changes really simple. Feel free to leave some > issues to followup patches. Changes in the qapi schema (new structs) require a rebase, so respin on its way. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
