On 04/27/2015 12:15 PM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> Previous commits demonstrated that the generator had several >> flaws with less-than-perfect unions:
>> +++ b/tests/qapi-schema/alternate-array.json
>> @@ -1,4 +1,4 @@
>> -# FIXME: we do not support array branches of anonymous unions yet
>> +# we do not support array branches of anonymous unions yet
>> # TODO: should we support this?
>> { 'type': 'One',
>> 'data': { 'name': 'str' } }
>
> FIXME added in PATCH 08, demoted to plain comment now. Any particular
> reason for the churn?
Poor rebasing skills on my part. I should have nuked the 'FIXME' out of
commit 8, instead of churning here.
>
> [...]
>
> Regardless,
Yeah, the churn doesn't hurt, and unless there's a good reason for a
respin, I'd rather see this series go in near the beginning of 2.4 since
the change to 'struct' later in the series WILL cause merge conflicts to
additions to *.json files, so sooner is better than later and fighting
repetitive rebases.
>
> Reviewed-by: Markus Armbruster <arm...@redhat.com>
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
