On Wed 15 Apr 2015 01:30:04 PM CEST, Paolo Bonzini wrote: > As far as the QMP parser is concerned, neither the 'O' nor the 'q' > format specifiers put any constraint on the command. However, there > are two differences: > > 1) from a documentation point of view 'O' says that this command takes > a dictionary. The dictionary will be converted to QemuOpts in the > handler to match the corresponding HMP command.
Is that documentation the comments in monitor.c? It could also be a good moment to document there 'q' as well. Otherwise the patch looks good to me, Reviewed-by: Alberto Garcia <[email protected]> Berto
