On 30/03/2015 10:36, Lin Ma wrote: > The patchset adds a generic can_be_deleted callback to UserCreatableClass. > It prevents removing a usercreatable object if the callback returns false. > > Backends could implement the callback if it shoudn't be removed while it's > in use. > > Thank Peter Crosthwaite, Paolo Bonzini, Andreas Färber and Igor Mammedov for > helping review. > > > ChangeLog: > V6: > Change prototype of user_creatable_can_be_deleted. > from bool user_creatable_can_be_deleted(Object *obj, Error **errp) > to bool user_creatable_can_be_deleted(UserCreatable *uc, Error **errp) > > V5: > Use specific caster instead of dynamic cast in user_creatable_can_be_deleted. > > V4: > Add function user_creatable_can_be_deleted to wrapper can_be_deleted method. > Remove some unnecessary code. > > V3: > Move the callback to the correct place: UserCreatableClass. > Move the backend callback implementation to hostmem.c. > > V2: > Make it generic, add the can_be_deleted callback to TypeInfo and TypeImpl. > Implement the callback in hostmem-file.c and hostmem-ram.c. > > V1: > Initial version, hard coded in object_del to prevent removing an in-use > host memory backend. > > > Lin Ma (2): > qom: Add can_be_deleted callback to UserCreatableClass > hostmem: Prevent removing an in-use memory backend > > backends/hostmem.c | 14 ++++++++++++++ > include/qom/object_interfaces.h | 13 +++++++++++++ > qmp.c | 5 +++++ > qom/object_interfaces.c | 12 ++++++++++++ > 4 files changed, 44 insertions(+) >
Thanks, looks good for 2.3. Paolo
