On 20 March 2015 at 22:52, Chen Gang <[email protected]> wrote: > On 3/21/15 01:48, Peter Maydell wrote: >> On 20 March 2015 at 15:25, Chen Gang <[email protected]> wrote: >>> 10 files changed, 3523 insertions(+) >> >> If you have any patch which has a diffstat like this then >> you *must* split it up into separate patches. Even >> 1000 lines is really too long to be easily >> reviewable, and this patch is now over three times >> that size! Most patches should be 250 lines or >> less, really, unless they're very mechanical. >> > > OK, thanks. I shall try to split it into 3 patches in patch v8.
Even 3 would still leave at least one of them more than 1000 lines. I would suggest that you should be thinking more like turning this one into 7 or 8 patches. -- PMM
